Skip to content

WIP: Fix discrepancy between NEO/go and NEO/py: Expand ~ in TLS key/certificate file paths

Levin Zimmermann requested to merge levin.zimmermann/neoppod:twtilde into t

Good day Kirill,

as we discussed in https://lab.nexedi.com/nexedi/slapos/merge_requests/1307 I started to work on a patch for NEO/go which lets NEO/go expand the ~ prefix for the TLS key/certificate file paths.

I implemented the functionality in the new xpath package (maybe it's rather an extension of os/user than of path?).

I locally run go test in neo/go/neo path and tests passed so far.

While I added unit tests for the new ExpandTilde function, I didn't add specific tests inside client_tests yet. My initial idea is to add one more option to NEOPySrv which declares whether the base path for the certificates/keys is with ~ or without ~. Then we switch between this new option here. Does this sound reasonable to you?

Best, Levin

/cc @kirr

Merge request reports