Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • N neo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Kirill Smelkov
  • neo
  • Merge requests
  • !1

WIP: Fix discrepancy between NEO/go and NEO/py: Expand ~ in TLS key/certificate file paths

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Levin Zimmermann requested to merge levin.zimmermann/neoppod:twtilde into t Jan 11, 2023
  • Overview 13
  • Commits 2
  • Pipelines 0
  • Changes 3

Good day Kirill,

as we discussed in https://lab.nexedi.com/nexedi/slapos/merge_requests/1307 I started to work on a patch for NEO/go which lets NEO/go expand the ~ prefix for the TLS key/certificate file paths.

I implemented the functionality in the new xpath package (maybe it's rather an extension of os/user than of path?).

I locally run go test in neo/go/neo path and tests passed so far.

While I added unit tests for the new ExpandTilde function, I didn't add specific tests inside client_tests yet. My initial idea is to add one more option to NEOPySrv which declares whether the base path for the certificates/keys is with ~ or without ~. Then we switch between this new option here. Does this sound reasonable to you?

Best, Levin

/cc @kirr

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: twtilde
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7