Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • cloudooo cloudooo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • cloudooocloudooo
  • Merge requests
  • !28

manager/getAllowedExtensionList: use explicit extensions in ERP5 legacy mode

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/compat-erp5-html-extension into master Mar 29, 2021
  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 2

In python2, mimetypes module was not deterministic and this snippet:

import mimetypes; print(mimetypes.guess_extension("text/html"))

use to be ".html" on python 2.7.14, but is ".htm" on python 2.7.18

Similarly:

import mimetypes; print(mimetypes.guess_extension("application/msword"))

was ".doc" on 2.7.14 and ".dot" on 2.7.18 (this was in my observations, this does not look deterministic as it is iterating on a dict, maybe this behaviour is not always same)

For html conversion engine, ERP5 expect that the extension for text/html is .html, not .htm. Some tests also expect that the conversion for word is .doc so to keep compatibility with extensions used in ERP5 compatibility mode, define explicitly these two extensions instead of depending on python standard library.

Edited Mar 29, 2021 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/compat-erp5-html-extension
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7