Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1009

renderjs_ui: "Touch" cache manifest in Post-Upgrade

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge feat/upgrader_website_cache into master Dec 20, 2019
  • Overview 10
  • Commits 1
  • Pipelines 4
  • Changes 10

With the current architecture of cache manifest, it was required that developpers change the cache manifests referencing a web page every time they change a web page. In practice, developers were never doing this, so we sometimes had issues where client keep using old version of website even though a new version has been deployed, when after deployment we did not change the cache manifest.

To automate the scenario of modifying the cache manifest, introduce a post-upgrade constraint that will check that the manifest is newer than all of the referenced pages. If that's the case, the constraint can fix by modifying the manifest content, which also changes the modification date of the manifest, which might be used in "if-modified-since" negociations.

According to spec [1], cache manifest is updated if the HTTP responses is not "304 not modified" and if the manifest content is not byte-for-byte identical to the previously cached version.

[1] https://www.w3.org/TR/2008/WD-html5-20080122/#updating1

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feat/upgrader_website_cache
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7