Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1021

Check forms in coding style

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge feat/coding_style_form_naming into master Dec 27, 2019
  • Overview 5
  • Commits 56
  • Pipelines 11
  • Changes 256

Extend coding style tests to check forms:

  • Method Name Is Prefixed With Portal Or Meta Type, Class Or Interface / Set Document Form Ids To PortalType_view - this was checked for python scripts, but not yet for dialogs
  • Form Name Uses Lowercase View After Portal Type
  • Dialog Form Name Is Postfixed With Dialog
  • Report Name Uses Portal Type Followed By View Report Name And Report
  • Place Simulation And Validation Fields At Bottom Of Right Group
  • Use Correct Names For Simulation And Validation Titles

and apply minimal fixes to all business templates already running coding style checks.

Edited Dec 10, 2020 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feat/coding_style_form_naming
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7