Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1088

PdfFileReader: avoid to overwrite warnings

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Gabriel Monnerat requested to merge gabriel/erp5:fix_pdf_file_reader into master Mar 26, 2020
  • Overview 17
  • Commits 1
  • Pipelines 0
  • Changes 2

We already overwrite it in ERP5Type/Utils.py, then _showwarning method from PyPDF2 breaks ERP5

PyPDF2 can not overwrite _showwarning, because we already did it.

I tried to extend test.erp5.testERP5PDFMerge to reproduce this issue, but I can not catch it in unit test. Any idea?

/cc @romain, @vpelletier

Edited Apr 28, 2020 by Gabriel Monnerat
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_pdf_file_reader
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7