Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1163

advanced_ecommerce: remove problematic script

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Jérome Perrin requested to merge fix/advance_ecommerce_coding_crimes into master Jun 19, 2020
  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 7

This script:

  • redirects with password in URL, which causes password to be in log files and web analytics software
  • uses "immediate reindex"
  • uses manage_setLocalRoles instead of proper roles definitions (so roles are lost when roles are regenerated and other problems)

A more proper way seem to use credential request

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/advance_ecommerce_coding_crimes
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7