Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1190

OAuthTool: Used only as a Folder ({Google,Facebook}Connector) so remove {unused,unmaintained,unfinished} code.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Arnaud Fontaine requested to merge arnau-RD-Components-ERP5TioSafe into master Jul 07, 2020
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 33

Properties are statically sets on portal_oauth directly with classes define in OAuthTool.py. This prevents migration to ZODB Components as erp5_oauth could not be upgraded anymore (chicken & egg issue: we need these classes portal_templates.download() (importFile(portal_oauth.xml)) but they are not available until the bt5 is installed...).

Considering that several properties are supposed to be private but statically set in OAuthTool.py (and it seems there is no way to change them), and that this code has never been used since its introduction 9 years ago, I think it is better remove that code than trying to fix it properly.

@nexedi @aurel Is that ok with you? (All Unit Tests pass) I will wait a few days for anyone to reply and then merge.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: arnau-RD-Components-ERP5TioSafe
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7