Skip to content

WIP: inconsistent listbox proxy fields for modules

Jérome Perrin requested to merge jerome/erp5:listbox_module_proxy_field into master

Since 76282344 , most modules do not have a count method anymore.

But not all of them, because we have two proxy fields for listboxs , my_list_mode_listbox and my_view_mode_module_listbox that are not used consistently.

$ git grep  my_list_mode_listbox | wc -l
196
$ git grep  my_view_mode_module_listbox | wc -l
64

According to https://www.erp5.com/erp5-HowTo.Configure.Proxy.Field/erp5-Guideline.Form.Profixification/#the-semantic-field-name-needs-to-be-associated-with-the-technical-context the technical_context_name for module listbox is list_mode, so my understanding is that modules should not use my_view_mode_module_listbox because this is not view_mode, so my_list_mode_listbox sounds better.

I am planning to change all users of my_view_mode_module_listbox to use my_list_mode_listbox , but I would like to make sure my understanding is correct and we agree on this.

/cc @seb @vpelletier @gabriel @romain @jm @kazuhiko @yusei

Merge request reports