Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1272

accounting: fix validation of accounting transactions with too precise amounts

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/accounting_rounding_validation into master Sep 23, 2020
  • Overview 5
  • Commits 1
  • Pipelines 3
  • Changes 11

Round the amounts line by line when validating transactions balances and showing the totals on an accounting transaction.

Even though float field configurations do not allow users to input transactions where amounts uses more digits that what makes sense for the selected currency, we had cases where some transactions generated by custom scripts were "too precise" and passed the validation because unlike in all reports where we display sum of rounded values, the check was only rounding the sum, which cause some transactions with 1.00 on one side and 0.333333 0.333333 and 0.333333 on the other side to be valid.

The scripts used to display sums on an accounting transaction had the same problem, they were also showing the rounded sum and not the sum of rounded values.

Edited Sep 23, 2020 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/accounting_rounding_validation
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7