Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1323

authentication_policy: fix UnicodeDecodeError with invalid password messages

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/change_password_policy_unicodeerror into master Dec 24, 2020
  • Overview 7
  • Commits 1
  • Pipelines 2
  • Changes 3

When new password does not match policy, in reset password and change password dialogs, we used u' '.join([str(message) ...]) to join all translated messages in a string, but this construct will decode the str(message) to unicode using ascii, so it will fail when these messages contain some multi bytes characters.

Extend test coverage to check that these dialogs uses translations and use non ascii messages in the tests, to make sure we don't have regressions with this issue.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/change_password_policy_unicodeerror
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7