Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1335

web_renderjs_ui: use lxml to extract data-i18n messages

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge feat/lxml-message-extract into master Jan 14, 2021
  • Overview 4
  • Commits 1
  • Pipelines 8
  • Changes 4

The previous regular expression based approach sometimes could not extract message properly. Using xml parser simplify code and fix several messages that were not extracted properly, like messages containing ", [] or {}

This also fix some problems when looking for messages sources:

  • archived web pages were sometimes used instead of published ones
  • messages from gadgets implemented as page templates/OFS files were not extracted.

A few more unit tests for the scripts involved in this process are added.

Edited Jan 19, 2021 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feat/lxml-message-extract
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7