Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1336

accounting: Fix timezone issues when checking periods are consecutive

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/accounting-period-dates-timezone into master Jan 15, 2021
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

Opening an accounting period is refused if the start date of the period is more than one day after the stop date of the previous period, but this check did not take into account that "next day" might be more than 24 hours, like it's the case when daylight saving happen between these dates. Instead we check that the difference is less than 1.9 days.

Reorganise tests to group accounting period related tests in a dedicated test class and add missing tests for period validation checks.

Also fix a few race conditions with catalog indexing that are probably not a problem in real life but were revealed by the test.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/accounting-period-dates-timezone
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7