Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1364

configurator_standard: repair accounting generation with default accounts

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/configurator-default-accounts into master Feb 19, 2021
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 9

in 772d8fed (configurator_standard: use specific sale and purchase business processes, 2020-07-16) we introduced scripts to look up dynamically accounts to use for expense/income and VAT accounts, from supply lines, but this accidentally broke the case where no account can be found on supply lines: in this case, the accounting line was not generated.

Ideally, there should be fallback accounts, to keep the same behavior and also to prevent generation of incomplete transactions.

Review the scripts, so that the "Dynamic" scripts fallback on the account defined on the trade model path if not found and introduce new scripts, where the account is not taken dynamically, but only from the trade model path, for use on the payable/receivable lines (where we don't want to lookup the account dynamically, otherwise we'll use same account as for expense/income)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/configurator-default-accounts
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7