Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1374

deferred_style: Properly keep request parameters

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/deferred_style_keep_request_form into master Mar 11, 2021
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 10

When rendering reports, deferred style was only keeping request.other, but some places, like Products.ERP5Form.ListBox.ListBox.getParamDict read only in request.form, which caused different behaviours when rendering reports directly or in activities, because when rendering in activities request keys that the report dialog might have pushed were not preset in request. They were of course present when rendering the report directly, because this was the same request, so this lead to different behaviours wether reports were rendering in activities or directly, like we could observe in 7058ab6f (accounting: fix grouping option of GL when running in deferred mode, 2021-02-25)

This change deferred style to properly propagate request.other and request.form in all activities of reports.

Edited Mar 29, 2021 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/deferred_style_keep_request_form
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7