Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1394

Improvements on folder migration

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Roque requested to merge rporchetto/erp5:roque_officejs into master Apr 12, 2021
  • Overview 16
  • Commits 2
  • Pipelines 0
  • Changes 5

Control on ERP5Site_setNewIdPerBundle if id remains equal

It could be that the method to determine the new id during a folder migration returns the same id of the object (this is, there is an intention to not change the ids of certain objects) and ERP5Site_setNewIdPerBundle will fail as it will try to do object.setId(same_id).

This merge request adds a control for cases like this to allow migrations of that tipe.

For example in https://lab.nexedi.com/nexedi/officejs-appstore/merge_requests/16, the script Base_generateIdFromCreationDate returns a new id format only for default int ids. For custom ids, it returns the same old_id to avoid breaking something after a module migration.

Bundle parameter configurable on folder migration and higher migration priority

To ensure the number of activities doesn't increase infinitely with large module contents and to prevent conflicts on the module itself

Edited Apr 21, 2021 by Roque
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: roque_officejs
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7