Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !141

Closed
Created Jul 12, 2016 by Ayush Tiwari@tiwariayushContributor
  • Report abuse
Report abuse

ERP5 Subcategory: Rename 'multiple_selection' subcategory to solve name conflicts.

  • Overview 4
  • Commits 1
  • Changes 3

Subcategory 'multiple_selection' has been renamed to 'multiple selection' to maintain consistency.

Earlier, whenever a new StandardCategory object was created with property_type 'multiple selection', one needed to change the elementary type explicilty to use it to generate property setters and getters.

The example for this can be seen from this commit: https://lab.nexedi.com/nexedi/erp5/commit/fd7387538a120307317c6c81cbe2399a866cdbb6 After this change, in the view, property type field couldn't recognize the property and displays (???multiple selection).

Also, everywhere in erp5, list_types do mention 'multiple selction' and not 'multiple_selection'. So, its better to maintain consistency in naming the subcategory.

The tests are running for this change via this test suite. (https://nexedi.erp5.net/test_suite_module/294) We wait for them to pass before merge, although I have rechecked the changes in a separate new instance.

Please review: @romain @gabriel

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: erp5_multiple_selection_conflict
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7