Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1556

ERP5{,Type.Core}.InteractionWorkflow: Deprecate activeScript.

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Vincent Pelletier requested to merge vpelletier/erp5:depreate_activeScript into master Feb 17, 2022
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 3

Replace it with a method on ERP5Type.Base so these activities get found by CopySupport.unindexObject and flushed, rather than remaining on the interaction workflow's context and failing when run. It seems a lot more likely for a document to be deleted while interactions are being spawned than an interaction workflow itself. So this should be a net benefit in activity stability.

The reason behind this change is that untitests fail en masse in beforeTearDown when erp5_local_transaction is installed: it has an interaction which spawns an activeScript activity, whose context is the interation workflow. Then, beforeTearDown deletes the object before this activity could be run. Because the activity context is not the document, it does not get flushed by CopySupport.unindexObject, so when beforeTearDown then calls self.tic() it fails because the activity cannot run (cannot traverse to the now-deleted document).

/cc @arnau @jerome @jm @romain (not sure who else have ideas & feedback on this topic)

Edited Feb 17, 2022 by Vincent Pelletier
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: depreate_activeScript
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7