Skip to content

amount_generator: refresh "Trade Model" view on deliveries and delivery lines

Julien Muchembled requested to merge view-aggregated-amounts into master

It's been a few years since getAggregatedAmountList should be called on the delivery or the movement, and a single form for both levels is enough.

This commit also adds a form to view non-aggregated amounts. We still have to decide where to put a link to view it: a new tab would be too much. For this form, it would be also interesting to add a column to the delivery/movement being processed (currently, a private _base attribute on each amount).

Rows don't link anywhere. This could be changed to jump the causality object (e.g. Trade Model Line).

At last, maybe erp5_base or erp5_simulation would be a better place than erp5_trade for these forms, except that it's not trivial to move because they use Base_viewTradeFieldLibrary.

TODO:

  • in contribution/application columns, display variations

/cc @jerome @seb @kazuhiko @yusei

Merge request reports