Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1578

TargetSolver: use simple date arithmetics instead of createDateTimeFromMillis

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/drop_createDateTimeFromMillis into master Mar 18, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Maybe this made sense long time ago, but nowadays we are using equivalence testers which tolerate date differences with more flexibility.

createDateTimeFromMillis was also problematic as it uses internal private attributes of DateTime which is a pylint error with more recent DateTime

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/drop_createDateTimeFromMillis
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7