Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !162

jupyter: erp5_kernel now correctly persists new-style classes without `_p_jar`

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Douglas requested to merge Camata/erp5:hotfix/matplotlib-figure-persist into master Sep 12, 2016
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

If ERP5 Jupyter kernel tried to persist an object created from a new-style class, it would crash because the object has no _p_jar. This makes the creation of the ObjectWriter fails. This kind of object needs to be handled by (c)Pickle.

Related to bug report https://nexedi.erp5.net/bug_module/20160819-882FA2, created by @kasra.

@Tyagov, please review when possible.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hotfix/matplotlib-figure-persist
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7