Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1818

Ignore read-only transaction cache when getting a category from a new or temp object

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Julien Muchembled requested to merge ro-cache into master Sep 05, 2023
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 1

The purpose is to be able to use the amount generator during indexation. At some point, it executes:

    if amount.getQuantityUnit():
    ...
    for x in property_dict.iteritems():
      amount._setProperty(*x)

where amount.getQuantityUnit() may getResource before it is set. Any further access to the resource category would be wrong.

There may be a way to only change the amount generator but this kind of pitfall is likely to happen in many other places if we keep such a read-only transaction cache for new or temp objects.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ro-cache
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7