Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1820

ListBox: fix possible unexpected acquisition

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Julien Muchembled requested to merge fix-cell-aq into master Sep 06, 2023
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 1

The use case is a listbox method being called for a document A and returning objects that:

  • aren't children of A
  • but wrapped with .__of__(A)

By using aq_self instead of aq_base, the listbox could still acquire from the real parent of the returned object and wrongly access an attribute directly (e.g. comment) instead of using an appropriate method (if there's no comment attribute, getComment returns '').

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-cell-aq
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7