Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !183

ListBox: Navigation methods should not be created when rendering ListBox (#20161014-741678).

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Arnaud Fontaine requested to merge arnau into master Oct 16, 2016
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 11

These methods were generated when rendering the ListBox and with the id of the ListBox in their name. However, a customer reported the following problem on Accounting Periods ListBox:

  1. Display Accounting Period ListBox on ZEO-1. => The ListBox will be rendered and 'listbox_period_list_*' methods will be generated on ZEO-1.
  2. Click on 'Next Page' button and the user is redirect to ZEO-2 where the ListBox has never been generated. => The method does not exist yet and thus a 404 error is raised.

Instead of having one method per ListBox ID, only one is now created (eg listbox_setPage() for SelectionTool.setPage()) at Zope startup and the ListBox ID previously defined in the method name is now defined in the value attributes of the buttons.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: arnau
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7