Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1835

dms: version up pdfjs 3.11.174

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge feat/pdfjs_up into master Oct 26, 2023
  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 268

using pdfjs-3.11.174-legacy-dist.zip

Note: viewer.js is modified to do nothing in webViewerLoad (one line with return "ERP5 patch: disable here" is added at the top of this function) because we do the initialization in the gadget. I think something similar was also done with the previous version.

The tests were extended to cover:

  • opening an empty or broken PDF: this should not crash
  • clicking save: this should not crash and the updated document should render properly. The save action replaces the ERP5 document content with the content from the editor, so if user for example added annotations or draw on the PDF, the modified version is saved. We don't use this feature and it's not so easy to test, so for now the test only covers the "it should not crash and it should not break the document".
  • entering wrong password for encrypted PDFs should not crash
Edited Nov 16, 2023 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feat/pdfjs_up
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7