Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !184

Authentication policy fixes

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge authentication_policy_fixes into master Oct 19, 2016
  • Overview 10
  • Commits 5
  • Pipelines 0
  • Changes 4

This MR contains fixes for two bugs for erp5_authentication_policy:

  • passport expiration feature was only working if getPreferredNumberOfLastPasswordToCheck was set, because password events are created only in that case. So the case where we only have a maximum password duration was not working.
  • automatic password request was not working, a bug innotifyPasswordExpired script made that the credential request was not created. That problem remained unoticed, partially because PAS catch errors and log them with level debug only. We may want to change PAS to log with a higher log level.

At the same time, while introducing some new tests for that first problem, I noticed that tests were not properly isolated, for example test_05_PasswordExpire was only working when running after test_02_PasswordHistory, because test_02_PasswordHistory was enabling this password event logging, so I also refactored the tests a bit so that they don't depend on others so much. This way we can use --run-only or add a new test without breaking others.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: authentication_policy_fixes
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7