Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1913

Do not overwrite `output.write` in live tests.

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Carlos Ramos Carreño requested to merge vnmabus/erp5:feature-live-test-output-write into zope4py3 Apr 10, 2024
  • Overview 12
  • Commits 40
  • Pipelines 0
  • Changes 772

The write method of the output object was being overwritten in live tests, replacing it to a function that printed both to the output and to stdout. This was not necessary, as it is possible to use this function directly. Moreover, the function code had two flaws:

  • It assumed that output was a particular (StringIO) class. This caused a problem during the migration (commit 80bd30fc).
  • It printed to stdout instead to stderr.

Using the function directly allows output.write to be used inside it, preventing the first flaw. The second flaw has also been solved.

Edited Apr 10, 2024 by Carlos Ramos Carreño
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature-live-test-output-write
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7