Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1929

Fix `po_import` behavior in Python 2

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Carlos Ramos Carreño requested to merge vnmabus/erp5:fix/testLocalizer_py2 into zope4py3 Apr 23, 2024
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

Newer versions of polib accept only unicode strings in the pofile function (because they check if they start by the decoded version of the BOM). I changed the data that is passed to pofile to be a unicode string in Python 2 too. This seems to work locally in my old version of polib, so that at least the old behavior should be kept the same.

Tests for testLocalizer pass in both Python 2 and Python 3.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/testLocalizer_py2
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7