Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !1938

accounting: fix error in Journal report with lines with an acquired node

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/journal-acquired-node into master May 16, 2024
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

If a transaction is selected but instead of having accounts as source/destination on lines it acquires the organisation set as source/destination on the transaction, this causes an AttributeError getGapList when trying to use this organisation as an account.

To fix this, adjust the getMovementHistoryList parameters to select only lines using accounts, by passing node_uid, which is O(n) on the number of accounts, but the number of accounts is not supposed to be too large and other reports also do this assumption.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/journal-acquired-node
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7