Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !2026

oauth_google_login: support refresh when refresh_token is still valid

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/google-logout into master Dec 12, 2024
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

When refresh_token is still valid google's endpoint does not include the current refresh token in the response when refreshing the token, we need to keep the current one.

This fixes user logout every one hour.

That the old implementation before c3488a67 was doing something similar in https://github.com/googleapis/oauth2client/blob/v4.0.0/oauth2client/client.py#L781

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/google-logout
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7