Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !2111

OOoUtils: fix `OOoBuilder.replace` creating duplicate entries in zipfile

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/OOoUtils_duplicate_zip_entries into master May 28, 2025
  • Overview 7
  • Commits 1
  • Pipelines 8
  • Changes 3

This cleans up the API a bit:

  • OOoBuilder.updateManifest is no longer a public API, OOoBuilder handles manifest by itself and it's not necessary to call this method.
  • creating an OOoBuilder from an open file-like is no longer possible, it was not clear what the use case for this was.

Internally, this new implementation works by opening the zip file in the constructor and keeping the content of each file in a dict.

Edited Jun 06, 2025 by Jérome Perrin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/OOoUtils_duplicate_zip_entries
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7