Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !222

More authentication policy fixes after switch to login

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge jerome/erp5:fix/check_authentication_policy into master Jan 12, 2017
  • Overview 11
  • Commits 11
  • Pipelines 0
  • Changes 20

This contains the remaining fixes around authentication policy after the introduction of ERP5 Login.

Here I am changed API so that login_account_provide's analyzePassword directly returns the messages instances and not error code, this way we can easily use analyzePassword to check passwords in various password fields validator.

You may think "why don't we use the same script for all validators ?", the answer is that depending on the context, the logic to find the login for which we want to check the password is different ( when "changing own password", it is the currently logged in user, in portal password password reset it is as we dicussed in https://lab.nexedi.com/nexedi/erp5/merge_requests/185#note_19760 , in new user creation dialog it would also be different), so it makes sense to have different validator scripts all reusing analyzePassword .

This was applied to Password tool to fix #20161021-F85D7 and also to Preference's tool "change own password" dialog.

There are other small fixes.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/check_authentication_policy
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7