Skip to content

Harmonize views and properties for amount generator Portal Types

Titouan Soulard requested to merge tsoulard/erp5:for-mr-turtle into master

I was recently writing a constraint checking effective and expiration dates on all Portal Types in amount_generator group. These include Trade Conditions and similar documents. When doing so, I noticed that Transformation did not have such properties, then that it was lacking some other Property Sheets, so I updated the component and view.

In the meanwhile, I also harmonized view so they look as similar as possible between Trade Conditions and both Transformation and Pay Sheet Models, to follow the idea of consistency of user interfaces in ERP5. Changes should not be too opinionated, but still if you have comments let me know, I am awaiting Test Result before merging in case something broke.

/cc @jerome @Nicolas @xiaowu.zhang

Merge request reports