Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !240

SimulationTool: allow also ledger_uid to be used as join_column for selection_domain

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Georgios Dagkakis requested to merge georgios.dagkakis/erp5:simulation_tool_join_column into master Mar 20, 2017
  • Overview 16
  • Commits 4
  • Pipelines 0
  • Changes 14

@vpelletier @jerome we have discussed about this at some points

In the past, a Domain Tree in a Listbox whose list_method uses simulation query (getInventoryList or getMovementHistoryList) could use only node_uid as join column. I started working on this trying to add support for ledger_uid in PaymentTransactionGroup_view. So this merge request contains kind of both changes, but they come from the same stream of work.

More specifically 3 commits:

  • First tries to give a more flexible definition of join_column based on a mapping that is one an erp5_core PythonScript, so can be overwritten for a project. Still it is not perfect, since it does not support the case of e.g. "have a domain on site category sometime used as node_category and sometimes as mirror_node_category or section_category".
  • Second makes the change in PaymentTransactionGroup_view. There is one more change that is adjacent. In the past PaymentTransactionGroup_view would list only Accounting Transaction Lines whose parents are Payment Transactions. Now we support also Accounting Transaction Lines whose parents are Accounting Transactions. I think this is an acceptable generic change, but you may comment.
  • Third renames some scripts, commit message is explanatory I think
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: simulation_tool_join_column
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7