Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !250

cleanup acquisition base categories in categories and properties definition

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Kazuhiko Shiozaki requested to merge cleanup_acquisition_base_category into master Apr 05, 2017
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 57

We no longer use order/delivery category to acquire categories and properties. Having needless acquisition base categories in category/property definition makes accessor slower. Yes, category accessor is slow in ERP5. So I propose to drop order and delivery from acquisition base categories from generic business templates.

One thing I'm still wondering is specialisethat is only used in variation's acquitision base categories. Is it really required ? I think that in getAggeregatedAmountList() usage, specialise is anyway taken into account by asComponent() result and we don't need explicit acquisition in variation base category. At least I find no reason to have specialise only in variation.

/cc @nexedi

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cleanup_acquisition_base_category
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7