Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !259

Merged
Created Apr 12, 2017 by Jérome Perrin@jeromeOwner

Don't call a useless getPrice on edit(price=x)

  • Overview 3
  • Commits 2
  • Changes 2

Base.edit has this feature of not actually modifying the properties when the new property value is same as the current one, so when we do movement.edit(price=x), this will cause an implicit getPrice.

As price lookup is a bit slow, do not lookup price in this case.

/cc @vpelletier @kazuhiko @romain

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feat/no_getPrice_on_edit
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7