Skip to content

Fix upgrader activity dependencies

Nicolas Wavrant requested to merge Nicolas/erp5:fix-upgrader into master

Currently the full-upgrade alarm calls the 3 upgrade-related-alarm's activeSense methods in activities. As activeSense method runs Alarm's methods in activities too, the final activities do not get the good "tag" and "after_tag" values, which creates a lack of depency between them. In consequence, if we are not running the real upgrade (= just activeSense), no need to run post-upgrade's activeSense : indeed, post-upgrade constraints will be run on what are currently installed, and not on the result of the previous steps of the upgrader, which lead to a wrong and misleading consistency check.

This Merge Request intends to fix it by :

  • Adding a "activate_kw" parameter to activeSense method, which allow to configure its internal call to "activate"
  • Improving upgrader to remove the useless calls to activeSense, and properly parameterize activeSense's activity generation

Merge request reports