Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !300

full text: do not overwrite SQLCatalog_makeFullTextQuery

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge fix/full_text_script_conflict into master Jun 20, 2017
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 5

This is for #20170620-8BDEBE.

@kazuhiko is that approach OK ?

To be honest, I don't like so much to hardcode the possible scripts names in SQLCatalog_makeFullTextQuery like this, so we can discuss a better approach.

I considered the following approaches:

  • erp5_mysql_innodb's SQLCatalog_makeFullTextQuery call a script from portal_skins and each full text business template can define a skin folder containing this script. I did not want to create skin folders just for this and it seems more logical to have this code in portal_catalog than portal_skins;
  • Instead of using hardcoded scripts names, SQLCatalog_makeFullTextQuery calls the first script matching SQLCatalog_make.*FullTextQuery pattern, but this would be slow and we never use this approach anyway;
  • Have all implementions in erp5_mysql_innodb's SQLCatalog_makeFullTextQuery and let this script choose the best by introspecting catalog. Similar to what we do in SQLCatalog_makeTranslatedTitleQuery and SQLCatalog_makeSearchTextQuery (maybe this is better in fact).

/cc @vpelletier @tiwariayush

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/full_text_script_conflict
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7