Skip to content

full text: do not overwrite SQLCatalog_makeFullTextQuery

Jérome Perrin requested to merge fix/full_text_script_conflict into master

This is for #20170620-8BDEBE.

@kazuhiko is that approach OK ?

To be honest, I don't like so much to hardcode the possible scripts names in SQLCatalog_makeFullTextQuery like this, so we can discuss a better approach.

I considered the following approaches:

  • erp5_mysql_innodb's SQLCatalog_makeFullTextQuery call a script from portal_skins and each full text business template can define a skin folder containing this script. I did not want to create skin folders just for this and it seems more logical to have this code in portal_catalog than portal_skins;
  • Instead of using hardcoded scripts names, SQLCatalog_makeFullTextQuery calls the first script matching SQLCatalog_make.*FullTextQuery pattern, but this would be slow and we never use this approach anyway;
  • Have all implementions in erp5_mysql_innodb's SQLCatalog_makeFullTextQuery and let this script choose the best by introspecting catalog. Similar to what we do in SQLCatalog_makeTranslatedTitleQuery and SQLCatalog_makeSearchTextQuery (maybe this is better in fact).

/cc @vpelletier @tiwariayush

Merge request reports