Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !327

CMFActivity adapt hasErrorActivity to modern API

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Łukasz Nowak requested to merge luke/erp5:fix/hasErrorActivity into master Jul 24, 2017
  • Overview 4
  • Commits 4
  • Pipelines 0
  • Changes 5

ActiveObject and ActiveProcess provide hasErrorActivity method, which shall return True only in case when there is errornous activity related to given document (be it object or process).

Unfortunately those methods weren't tested and because of obsoletion of processing_node parameter, they were failing.

This MR provides:

  • addition of invalid_only parameter, which allows to check if there is any message which is failed (and failed is -2)
  • test covering various cases for hasActivityError
  • fix for hasErrorActivity using the invalid_only parameter
  • small reorganisation of global, which is not needed in ActiveObject anymore

Attached testCMFActivity.txt contains test result of testCMFActivity.py from source branch.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/hasErrorActivity
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7