Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !334

Hotfix/test listbox order

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Tomáš Peterka requested to merge hotfix/test-listbox-order into master Jul 27, 2017
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 10

ListBox "sort" field which describes default sort is implemented using ListTextAreaField. As you can see it replaces single value "V" with "V | V". This works for sort/search columns definition because they expect "column-name | title".

ERP5 (SelectionTool) is benevolent and gracefully omits such meaningless sort expression as "id | id" and sorts ASC by default.

Old UI is very nice to the implementator and shows sort as ascending in case it is not descending. Which is true but leaves the implementator to get lazy with definitions.

New UI refuses to show any sort which is not properly defined. Thus sort values in ERP5 has to be defined as "<column> | <order>". Examples: "id | ASC", "title | DESC".

Test Result https://nexedijs.erp5.net/#/test_result_module/20170727-1803130F

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hotfix/test-listbox-order
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7