Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !382

[erp5_core] Careful refactoring of Base_edit

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Tomáš Peterka requested to merge refactor/base_edit into master Sep 08, 2017
  • Overview 62
  • Commits 2
  • Pipelines 0
  • Changes 2

Whole @nexedi can be interested in this MR.

Please use "Hide whitespace changes" for the diff because often it is just a change of indentation.

Base_edit in json_style was refactored for correctness and readability. This MR brings those changes back to erp5_core. Full test suite passed on those changes https://nexedijs.erp5.net/#/test_result_module/20170908-EB5B74F

More comments why the refactoring was almost necessary on diffs in the code.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor/base_edit
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7