Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !460

Add constraint on Causality State for packing List

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Cédric Le Ninivin requested to merge cedric.leninivin/erp5:master into master Oct 18, 2017
  • Overview 15
  • Commits 8
  • Pipelines 0
  • Changes 18

For invoicing and delivering, transition requiring a "solved" causality state were testing for "building" and "diverged" states. This lead to errors as causality state can be "calculating" and heading toward divergence, but if the user is fast enough, the transition can be used before the activity marking the element as diverged.

After discussion it has been decided to move this verification on Constraint for the following reasons:

  • Having a message explain why the transition is blocked is simpler for users:
    • No need to explain to current users why their transition has gone (no formation or documentation is needed for the update)
    • Simpler for user to only remember their goal (doing the transition) and having a message explain them why they cannot
  • Bonus: The condition is verified on the transition which improve reliability.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7