Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !507

Non-existing CallableTool does not bring down the portal

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Tomáš Peterka requested to merge hotfix/callable_tool into master Nov 27, 2017
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

During erp_core upgrade, my instance failed on non-existing document.erp5.CallableTool. So foolish me created Portal Component "document.erp5.CallableTool" which content was rather simple

class CallableTool:
  pass

That gave me infinite loop in acquisition chain and brought my whole portal down. The correct implementation would be

from product.ERP5Type.Tool.BaseTool import BaseTool
class CallableTool(BaseTool):
  pass

@klaus and @tatuya please review if this fix is necessary or even good because I am unsure why it actually fixed my problem.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: hotfix/callable_tool
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7