Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !629

Test Suite for Coding Style test

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge experiment/coding_style_test_suite into master Apr 09, 2018
  • Overview 11
  • Commits 6
  • Pipelines 6
  • Changes 100+

A new test suite to perform static check on business templates using CodingStyleTestCase.

This runs a coding style test for each business template, after installing the business template and its dependencies listed in business template metadata.


In order to start with a test suite with no failure, business templates that does not pass this test today (because they don't install or because pylint issues still needs to be reviewed) are skipped with an ad-hoc bt/skip_coding_style_test in the business template. Note that this file is not created by business template system as it is a temporary measure, business templates must pass pylint and other checks from CodingStyleTestCase.


I took the approach of creating one independent test per business template, instead of the approach of creating a site with all business templates like we did in testNamingConventions or testHTML. This appears as another "Coding Style" test, like Performance or Scalability tests.

The idea behind this was that if we extend our business template checks ( for example when we translate the ERP5 Module Creation Guidelines to some scripts we can run on a business template ), we can check that each business template contain what it should contain and not just that the global result is OK.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: experiment/coding_style_test_suite
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7