Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !666

base: Image should not acquire local roles

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge jerome/erp5:fix/image_do_not_acquire_local_roles into master May 14, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

All top level documents are not supposed to acquire local roles https://www.erp5.com/erp5-Guideline.Unset.Acquire.Local.Roles.On.Document.Portal.Type.Configuration.If.Applicable

I believe this comes from the time where we were using images as sub-documents of products or persons. We now use embedded files for these cases, so no need to have an exception here.

Depending on the security configuration, there might be a notable side effect of applying this change: images that were visible by some users because they acquired Auditor role from the module will not longer be visible by these users, but they will still be indexed as visible, so they will appear in catalog searches. In such case, after re-indexing image module the catalog will be consistent again.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/image_do_not_acquire_local_roles
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7