Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !691

Coordinate reachability

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Georgios Dagkakis requested to merge georgios.dagkakis/erp5:coordinate_reachability into master Jun 11, 2018
  • Overview 12
  • Commits 5
  • Pipelines 0
  • Changes 60

This Merge Request adds reachability_workflow and adds it to all Coordinate types (Adress, Email etc.) so that the can be marked as reachable or unreachable. It also adds coordinate_interaction_workflow, so that when a coordinate text changes actions can be triggered. The default behaviour is that, when coordinate text changes for an 'unreachable' Coordinate, it is marked as reachable.

We already discussed this with @jerome , but I cc @nexedi , since this can break compatibility in projects, because in the past Coordinates acquired validation_state by their parent document (Person, Organisation, etc). So now, if some code checks getValidationState (though it should be checking on the parent) for Coordinate, or searches Catalog with validation_state (though it should be parent_validation_state), behaviour will change.

Test Result here seems good (3 failures in UI tests that seem unrelated)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: coordinate_reachability
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7