Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !70

Item tracking and movements in started state

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge revert-0168bf60 into master Mar 09, 2016
  • Overview 5
  • Commits 5
  • Pipelines 0
  • Changes 3

After that change, when there is a movement from A to B in started state, Item_getCurrentSiteValue will consider that this movement has already reached B.

Before this change, Item_getCurrentSiteValue was returning None, which somehow makes sense because started movement is in transit state, so the item has left A but not yet reached B, so it is in an unknown location. Low level current tracking list API ( getCurrentTrackingList ) does not return items for started movements. Honestly, I do not know if this is by design. ( @all anybody knows ? )

I will work on adding missing tests, but please tell me if I am wrong in thinking it should return None.

@gabriel @rafael @tb @tc do you remember why this change was introduced ? Maybe that behaviour of returning None should be only at the level of Item_get* scripts ?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: revert-0168bf60
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7