Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !740

Fix charset of web scripts

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge jerome/erp5:fix/web_script_charset into master Sep 07, 2018
  • Overview 18
  • Commits 6
  • Pipelines 0
  • Changes 8

Because web scripts are not served with an explicit content type encoding, they are interpreted as ISO-8859-1.

So it looks like this when we use translation gadget when running with accessing the HTTP server from runUnitTest :

CassÃ_

This is because runUnitTest's server uses iso-8859-15 as default encoding for responses, so the HTML page is served as Content-Type: text/html; charset=iso-8859-15 and later included javascript are also interpreted as this encoding.

Setting default response encoding to utf-8 in runUnitTest is enough to fix the visual glitch in the app, but when viewing the javascript source in the browser, we can see that there's another issue, so we also change the helper scripts to serve javacsripts, css and manifests with an explicit utf8 encoding.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/web_script_charset
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7