Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !777

Formulator: Do not add empty item if item_list is empty for SingleItemsWidget and MultiItemsWidget

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Georgios Dagkakis requested to merge georgios.dagkakis/erp5:drop_widget_dummy_value into master Oct 18, 2018
  • Overview 9
  • Commits 1
  • Pipelines 0
  • Changes 1

we used to add this value because select without option (that happens in MultiListField only) is invalid on XHTML.

But it was not at all required for other cases like MultiCheckboxField or RadioField.

Also, select without option is no longer invalid on HTML5.

Considering that showing dummy unselectable is anyway meaningless for users, we drop it for all cases.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: drop_widget_dummy_value
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7