Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedinexedi
  • erp5erp5
  • Merge requests
  • !804

Support Request: "Comment {Date,Author}" on frontpage

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jérome Perrin requested to merge jerome/erp5:fix/support-request-comment-date into master Nov 22, 2018
  • Overview 8
  • Commits 3
  • Pipelines 1
  • Changes 11

Originally, there was a regression introduce in my recent changes that "Comment Author" column was always empty.

This MR contains some more refactoring for "Comment Date" and "Comment Author" columns:

image

On the visible side, "Comment Date" column has been simplified, it used to show "hour:minutes" if the message was posted today, and "year/month/day" if the post was older. It's now a simple date time field (using Base_viewCRMFieldLibrary/my_event_start_date), for consistency.

On the implementation side, they now use existing SupportRequest_getCommentPostListAsJson script, which simplified code a lot. That script was also renamed as SupportRequest_getCommentPostList, because it's no longer returning JSON.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/support-request-comment-date
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7