Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • erp5 erp5
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 141
    • Merge requests 141
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !814

Merged
Created Dec 06, 2018 by Jérome Perrin@jeromeOwner

Configurator and workflow cleanups

  • Overview 3
  • Commits 13
  • Pipelines 1
  • Changes 34
  • Assorted small fixes so that form comply to conventions
  • Minimal fixes of invalid html
  • make mixin usable in type definition

The context is I was working on a custom configurator involving some matrixboxs, so I needed a simple business configuration item just to store the matrix result. This was possible with mixin, I just made a portal type based on Item class, enabling mxins for Matrix and BusinessConfiguratorItem and I did not have to define a class ( not sure this is really better ).

Then the matrixbox was not rendering properly, because browser was confused by the broken html and build a "different DOM" and selectors did not apply. This is what configurator: fix (a bit) invalid HTML addresses.

While doing this, fix some minor problems found with forms.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feat/configurator-workflow-cleanups
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7